change phone number display

This commit is contained in:
2026-04-26 15:24:05 -04:00
parent ad66fef19b
commit d64e1d5578
13 changed files with 57 additions and 14 deletions
+1
View File
@@ -0,0 +1 @@
{"version":2,"defects":{"Tests\\Feature\\MyWinningsTest::test_mywinnings_form_is_accessible":8,"Tests\\Feature\\MyWinningsTest::test_mywinnings_results_show_correct_data":8,"Tests\\Feature\\MyWinningsTest::test_mywinnings_invalid_bidder_shows_error":8},"times":{"Tests\\Unit\\PhoneFormattingTest::it_formats_a_10_digit_phone_number":0.018,"Tests\\Unit\\PhoneFormattingTest::it_strips_non_numeric_characters_before_formatting":0,"Tests\\Unit\\PhoneFormattingTest::it_returns_original_value_if_not_10_digits":0,"Tests\\Unit\\PhoneFormattingTest::bidder_model_accessor_formats_phone_number":0.003}}
+2 -1
View File
@@ -57,7 +57,8 @@ class BiddersResource extends Resource
TextColumn::make('bidder_city')->label('City')->sortable(),
TextColumn::make('bidder_state')->label('State')->sortable(),
TextColumn::make('bidder_zip')->label('Zip')->sortable(),
TextColumn::make('bidder_phone')->label('Phone Number')->sortable(),
TextColumn::make('bidder_phone')->label('Phone Number')->sortable()
->formatStateUsing(fn ($state) => \App\Helpers\PhoneHelper::format($state)),
TextColumn::make('bidder_email')->label('Email')->sortable(),
])
->filters([
+14
View File
@@ -0,0 +1,14 @@
<?php
namespace App\Helpers;
class PhoneHelper
{
public static function format($phone)
{
$phone = preg_replace('/[^0-9]/', '', $phone);
if (strlen($phone) == 10) {
return preg_replace('/([0-9]{3})([0-9]{3})([0-9]{4})/', '$1-$2-$3', $phone);
}
return $phone;
}
}
+1 -1
View File
@@ -66,7 +66,7 @@
{{ $bidderlist_result->bidder_zip }}
</td>
<td>
{{ $bidderlist_result->bidder_phone }}
{{ \App\Helpers\PhoneHelper::format($bidderlist_result->bidder_phone) }}
</td>
<td>
{{ $bidderlist_result->bidder_email }}
+1 -1
View File
@@ -33,7 +33,7 @@
Name: {{ $checkout_info_result->bidder_fname }} {{ $checkout_info_result->bidder_lname }}
</th>
<th colspan="2">
Phone Number: {{ $checkout_info_result->bidder_phone }}
Phone Number: {{ \App\Helpers\PhoneHelper::format($checkout_info_result->bidder_phone) }}
</th>
</tr>
<tr>
+1 -1
View File
@@ -51,7 +51,7 @@
Name: {{ $checkout_info_result->bidder_fname }} {{ $checkout_info_result->bidder_lname }}
</th>
<th colspan="2">
Phone Number: {{ $checkout_info_result->bidder_phone }}
Phone Number: {{ \App\Helpers\PhoneHelper::format($checkout_info_result->bidder_phone) }}
</th>
</tr>
<tr>
@@ -70,7 +70,7 @@
{{ $checkout_complete_result->bidder_zip }}
</td>
<td>
{{ $checkout_complete_result->bidder_phone }}
{{ \App\Helpers\PhoneHelper::format($checkout_complete_result->bidder_phone) }}
</td>
<td>
{{ $checkout_complete_result->bidder_email }}
+1 -2
View File
@@ -67,8 +67,7 @@
{{ $finaltally_result->bidder_zip }}
</td>
<td>
{{ $finaltally_result->bidder_phone }}
</td>
{{ \App\Helpers\PhoneHelper::format($finaltally_result->bidder_phone) }} </td>
<td>
{{ $finaltally_result->bidder_email }}
</td>
+1 -2
View File
@@ -49,8 +49,7 @@
Name: {{ $checkout_info_result->bidder_fname }} {{ $checkout_info_result->bidder_lname }}
</td>
<td colspan="2">
Phone Number: {{ $checkout_info_result->bidder_phone }}
</td>
Phone Number: {{ \App\Helpers\PhoneHelper::format($checkout_info_result->bidder_phone) }} </td>
</tr>
<tr>
<td>
+1 -2
View File
@@ -49,8 +49,7 @@
Name: {{ $checkout_info_result->bidder_fname }} {{ $checkout_info_result->bidder_lname }}
</td>
<td colspan="2">
Phone Number: {{ $checkout_info_result->bidder_phone }}
</td>
Phone Number: {{ \App\Helpers\PhoneHelper::format($checkout_info_result->bidder_phone) }} </td>
</tr>
<tr>
<td>
+1 -1
View File
@@ -78,7 +78,7 @@
{{ $showcarlist_result->bidder_zip }}
</td>
<td>
{{ $showcarlist_result->bidder_phone }}
{{ \App\Helpers\PhoneHelper::format($showcarlist_result->bidder_phone) }}
</td>
<td>
{{ $showcarlist_result->bidder_email }}
+1 -2
View File
@@ -20,8 +20,7 @@
Name: {{ $winnertotal_info_result->bidder_fname }} {{ $winnertotal_info_result->bidder_lname }}
</th>
<th>
Phone Number: {{ $winnertotal_info_result->bidder_phone }}
</th>
Phone Number: {{ \App\Helpers\PhoneHelper::format($winnertotal_info_result->bidder_phone) }} </th>
<th>
Total: ${{ $winnertotal_info_result->total_cost }}
</th>
+31
View File
@@ -0,0 +1,31 @@
<?php
namespace Tests\Unit;
use Tests\TestCase;
use App\Models\Bidders;
use App\Helpers\PhoneHelper;
class PhoneFormattingTest extends TestCase
{
/** @test */
public function it_formats_a_10_digit_phone_number()
{
$formatted = PhoneHelper::format('1234567890');
$this->assertEquals('123-456-7890', $formatted);
}
/** @test */
public function it_strips_non_numeric_characters_before_formatting()
{
$formatted = PhoneHelper::format('(123) 456-7890');
$this->assertEquals('123-456-7890', $formatted);
}
/** @test */
public function it_returns_original_value_if_not_10_digits()
{
$formatted = PhoneHelper::format('1234567');
$this->assertEquals('1234567', $formatted);
}
}